Remove sendNewPlaceNotification http call

[cp-sneh-s]

Changelog

ApiPlaceService :- update HTTPs function call for adding new place

Breaking Changes

• Modify HTTP function call for sendNewPlaceNotification with sendNewPlaceAddedNotification for adding new place.

Summary by CodeRabbit

• New Features
  • Removed the notification feature for newly added places, streamlining the user experience.
• Chores
  • Updated the GitHub Actions workflow for artifact uploads to a newer version, potentially enhancing the upload process.

[coderabbitai]

Walkthrough

The pull request includes updates to a GitHub Actions workflow configuration and a modification in a Kotlin service file. The workflow change involves upgrading the upload-artifact action from version v2 to v4, while the Kotlin service file sees the removal of the Firebase Functions dependency and the associated notification logic for new places.

Changes

File Path	Change Summary
.github/workflows/build.yaml	Updated uses: actions/upload-artifact@v2 to uses: actions/upload-artifact@v4
data/src/main/java/com/canopas/yourspace/...	Removed Firebase Functions dependency and notification logic for new places; renamed sendNewPlaceNotification to sendNewPlaceAddedNotification (now irrelevant).

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 615a1f8 and a670930.

Files selected for processing (1)

• data/src/main/java/com/canopas/yourspace/data/service/place/ApiPlaceService.kt (1 hunks)

Additional comments not posted (1)

data/src/main/java/com/canopas/yourspace/data/service/place/ApiPlaceService.kt (1)

19-19: LGTM! The constructor change aligns with the removal of the notification logic.

The removal of the functions parameter of type FirebaseFunctions from the constructor suggests that the class no longer depends on Firebase Functions. This change aligns with the removal of the associated logic for sending notifications when a new place is added.

Please note that this change indicates a shift in functionality, as the service will no longer send notifications related to new places being added. Ensure that the removal of this notification feature is intended and consider how users will be informed about new places going forward.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai generate interesting stats about this repository and render them as a table.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.