Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind9 DNSSEC #69

Merged
merged 9 commits into from
Nov 11, 2024
Merged

Bind9 DNSSEC #69

merged 9 commits into from
Nov 11, 2024

Conversation

panlinux
Copy link
Contributor

@panlinux panlinux commented Oct 25, 2024

SD-1579

This MP adds 3 documents to the guide:

  • DNSSEC explanation
  • DNSSEC deployment howto
  • DNSSEC troubleshooting

Something to note is that, in the pictures, I used ubuntu.com as an example domain, but that domain does not have DNSSEC enabled :(. I don't rely on that anywhere, not even in the explanation text, which uses isc.org mostly. It felt odd to highlight isc.org in the picture, where I think it draws more attention, but none of the Canonical or Ubuntu domains are DNSSEC enabled. So I left ubuntu.

@panlinux
Copy link
Contributor Author

I asked reviews from everybody, as I wasn't sure where this MP would end up otherwise, but don't feel obliged to review, ok? It would be awesome, though :)

Copy link

@basak basak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also excellent material for DNS in general. Is it worth making this more general?

Should there be an explanation of the various flags involved and their implications?

Minor suggestions inline.

explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
@panlinux
Copy link
Contributor Author

This is also excellent material for DNS in general. Is it worth making this more general?

We don't have a general DNS material indeed, but that's out of scope here. I added it to the backlog in https://warthogs.atlassian.net/browse/SD-1444

Should there be an explanation of the various flags involved and their implications?

You mean like RD (recursion desired), RA (recursion available) and others? They are not DNSSEC specific, so I didn't elaborate further on them. I think that's part of the doc suggestion above.

Minor suggestions inline.

Thanks

@panlinux
Copy link
Contributor Author

panlinux commented Nov 5, 2024

Should there be an explanation of the various flags involved and their implications?

We talked offline and this was about the trust-ad setting (ad flag in the DNS protocol). I'll expand on that a bit.

@panlinux panlinux force-pushed the bind9-dnssec branch 2 times, most recently from b8214df to 514350d Compare November 5, 2024 16:50
@panlinux
Copy link
Contributor Author

panlinux commented Nov 5, 2024

We talked offline and this was about the trust-ad setting (ad flag in the DNS protocol). I'll expand on that a bit.
Done.

Copy link
Member

@bryceharrington bryceharrington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked through grammar tune-ups to dnssec.md, but the technical content all looked really good (I learned a bit!) I nerded out a bit on grammar copyedits, sorry about that, but hope you find it useful.

I took a read-thru of dnssec-troubleshooting.md and left some comments. Looks pretty good overall, just some phrasing improvements.

I did a quick skim through install-dnssec.md, and didn't spot any obvious issues to mention.

This would certainly benefit from additional reviews, in particular Sally to sharpen phrasings up better, and maybe Sergio or someone else with strong bind9 know-how on the technical end.

how-to/networking/dnssec-troubleshooting.md Outdated Show resolved Hide resolved
how-to/networking/dnssec-troubleshooting.md Outdated Show resolved Hide resolved
how-to/networking/dnssec-troubleshooting.md Outdated Show resolved Hide resolved
how-to/networking/dnssec-troubleshooting.md Outdated Show resolved Hide resolved
how-to/networking/dnssec-troubleshooting.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
@panlinux
Copy link
Contributor Author

panlinux commented Nov 6, 2024

Thanks a lot, Bryce, excellent review!

Copy link
Collaborator

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, great guides - as usual, logically laid out and clearly explained. I've left some formatting suggestions, and a few questions inline.

explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
explanation/dnssec/dnssec.md Show resolved Hide resolved
explanation/dnssec/dnssec.md Show resolved Hide resolved
explanation/dnssec/dnssec.md Show resolved Hide resolved
explanation/dnssec/dnssec.md Outdated Show resolved Hide resolved
how-to/networking/install-dnssec.md Outdated Show resolved Hide resolved
how-to/networking/install-dnssec.md Outdated Show resolved Hide resolved
how-to/networking/install-dnssec.md Outdated Show resolved Hide resolved
how-to/networking/install-dnssec.md Outdated Show resolved Hide resolved
how-to/networking/install-dnssec.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! Really nice articles :)

@panlinux
Copy link
Contributor Author

Thanks, I'll clean up the commits, rebase, and merge

@panlinux panlinux force-pushed the bind9-dnssec branch 2 times, most recently from 2d44dcc to a69d0d5 Compare November 11, 2024 17:03
@panlinux panlinux merged commit 440a208 into canonical:main Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants