-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bind9 DNSSEC #69
Bind9 DNSSEC #69
Conversation
I asked reviews from everybody, as I wasn't sure where this MP would end up otherwise, but don't feel obliged to review, ok? It would be awesome, though :) |
6ce36ec
to
0c26872
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also excellent material for DNS in general. Is it worth making this more general?
Should there be an explanation of the various flags involved and their implications?
Minor suggestions inline.
We don't have a general DNS material indeed, but that's out of scope here. I added it to the backlog in https://warthogs.atlassian.net/browse/SD-1444
You mean like RD (recursion desired), RA (recursion available) and others? They are not DNSSEC specific, so I didn't elaborate further on them. I think that's part of the doc suggestion above.
Thanks |
We talked offline and this was about the |
b8214df
to
514350d
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked through grammar tune-ups to dnssec.md, but the technical content all looked really good (I learned a bit!) I nerded out a bit on grammar copyedits, sorry about that, but hope you find it useful.
I took a read-thru of dnssec-troubleshooting.md and left some comments. Looks pretty good overall, just some phrasing improvements.
I did a quick skim through install-dnssec.md, and didn't spot any obvious issues to mention.
This would certainly benefit from additional reviews, in particular Sally to sharpen phrasings up better, and maybe Sergio or someone else with strong bind9 know-how on the technical end.
Thanks a lot, Bryce, excellent review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, great guides - as usual, logically laid out and clearly explained. I've left some formatting suggestions, and a few questions inline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great! Really nice articles :)
Thanks, I'll clean up the commits, rebase, and merge |
2d44dcc
to
a69d0d5
Compare
a69d0d5
to
4249871
Compare
SD-1579
This MP adds 3 documents to the guide:
Something to note is that, in the pictures, I used
ubuntu.com
as an example domain, but that domain does not have DNSSEC enabled :(. I don't rely on that anywhere, not even in the explanation text, which usesisc.org
mostly. It felt odd to highlightisc.org
in the picture, where I think it draws more attention, but none of the Canonical or Ubuntu domains are DNSSEC enabled. So I left ubuntu.