virtiofsd: avoid option not always present #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The virtiofsd server changed a lot in recent years, the version in Noble is no more having the flock option. I considered doing a huge "if release then" but the benefit is minimal. We already link to upstreams collection of examples which has this and many more which all work depending on your needs and versions. Let us just take away the flock hint to avoid users of the more modern stack that does it well right away to be blocked by an error about non existing options. Signed-off-by: Christian Ehrhardt <[email protected]>
s-makin
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtiofsd server changed a lot in recent years, the version in Noble is no more having the flock option. I considered doing a huge "if release then" but the benefit is minimal. We already link to upstreams collection of examples which has this and many more which all work depending on your needs and versions.
Let us just take away the flock hint to avoid users of the more modern stack that does it well right away to be blocked by an error about non existing options.