Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kernel-crash-dump.md to add details about kdump enablement by default in 24.10 #54

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

khbecker
Copy link
Contributor

No description provided.

Copy link
Collaborator

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! :) I've left a couple of suggestions for consistency/clarity

@@ -20,12 +20,30 @@ For some of these events (kernel panic, NMI) the kernel will react automatically

When a kernel panic occurs, the kernel relies on the *kexec* mechanism to quickly reboot a new instance of the kernel in a pre-reserved section of memory that had been allocated when the system booted (see below). This permits the existing memory area to remain untouched in order to safely copy its contents to storage.

## KDump enabled by default

Starting in Oracular Oriole (24.10) the kernel crash dump facility may be enabled by default at install time of standard installs of Ubuntu Desktop or Ubuntu Server that meet the following requirements:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Starting in Oracular Oriole (24.10) the kernel crash dump facility may be enabled by default at install time of standard installs of Ubuntu Desktop or Ubuntu Server that meet the following requirements:
Starting in Oracular Oriole (24.10) the kernel crash dump facility can be enabled by default during standard Ubuntu Desktop or Ubuntu Server installations on systems that meet the following requirements:

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the original sentence a bit confusing to parse - let me know if my suggestion expresses the same intention (if not I can refine it a bit)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the "may" to "can" isn't quite right, as there is no option to enable it or disable it, and using "can" implies to me that it is optional. I wrote "may" originally to indicate that it will be enabled by default if the conditions were met, but if some edge cases I did not enumerate were not met, it wouldn't be enabled. I would be fine with changing it to "will".

Starting in Oracular Oriole (24.10) the kernel crash dump facility will be enabled by default during standard Ubuntu Desktop or Ubuntu Server installations on systems that meet the following requirements:

would probably be best.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds good to me :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit

## KDump enabled by default

Starting in Oracular Oriole (24.10) the kernel crash dump facility may be enabled by default at install time of standard installs of Ubuntu Desktop or Ubuntu Server that meet the following requirements:
- the system has at least than 4 CPU threads
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this should be "at least 4" or "less than 4" threads?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least 4 is what it should be. I rewrote that sentence a few too many times and should have cleaned it up a bit more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, happens to all of us :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit

Starting in Oracular Oriole (24.10) the kernel crash dump facility may be enabled by default at install time of standard installs of Ubuntu Desktop or Ubuntu Server that meet the following requirements:
- the system has at least than 4 CPU threads
- the system has at least 6GB of RAM, and less than 2TB of RAM
- The free space available in /var is more than 5 times the amount of RAM and swap space
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The free space available in /var is more than 5 times the amount of RAM and swap space
- the free space available in `/var` is more than 5 times the amount of RAM and swap space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit


Starting in Oracular Oriole (24.10) the kernel crash dump facility may be enabled by default at install time of standard installs of Ubuntu Desktop or Ubuntu Server that meet the following requirements:
- the system has at least than 4 CPU threads
- the system has at least 6GB of RAM, and less than 2TB of RAM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- the system has at least 6GB of RAM, and less than 2TB of RAM
- the system has at least 6GB of RAM, and less than 2TB of RAM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in latest commit

Copy link
Collaborator

@s-makin s-makin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) thanks for the changes!

@s-makin s-makin merged commit ddddd6e into canonical:main Sep 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants