feat(refresh): quit installer instead of restarting #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
approved these changes
Feb 29, 2024
That was driven by |
d-loose
force-pushed
the
refresh-quit
branch
2 times, most recently
from
8b88e0d
to
a4e2808
Compare
d-loose
force-pushed
the
refresh-quit
branch
from
a4e2808
to
64ef181
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
feat(refresh): quit installer instead of restarting
github-actions bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
feat(refresh): quit installer instead of restarting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refresh mechanism currently fails to launch the updated version of the UI once the ubuntu-desktop-bootstrap snap has been refreshed by subiquity, see canonical/ubuntu-desktop-installer#2377. This is because calling
execv(Platform.resolvedExecutable, [])from within the snap relaunches the old revision instead of the updated one.As a simple fix, we can just quit the installer and ask the user to relaunch it. I haven't figured out how to properly test this yet, but I don't see why this approach shouldn't work. In any case, merging this PR cannot make it worse than it currently is :)