-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render mas config from template #616
Open
Thanhphan1147
wants to merge
61
commits into
2/main
Choose a base branch
from
render_mas_config_from_template
base: 2/main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l/synapse-operator into install_mas_cli_in_synapse_rock
…l/synapse-operator into install_mas_cli_in_synapse_rock
Thanhphan1147
force-pushed
the
render_mas_config_from_template
branch
from
December 6, 2024 23:31
77eede4
to
4e4ff6d
Compare
Thanhphan1147
requested review from
javierdelapuente,
amandahla and
gregory-schiano
December 9, 2024 19:21
amandahla
reviewed
Dec 10, 2024
amandahla
reviewed
Dec 10, 2024
amandahla
reviewed
Dec 10, 2024
amandahla
reviewed
Dec 10, 2024
amandahla
reviewed
Dec 10, 2024
Test coverage for ad63e70
Static code analysis report
|
gregory-schiano
approved these changes
Dec 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, there's just a small typo to fix
raise MASContextNotSetError("Waiting for leader to set MAS context.") | ||
|
||
# The leader unit skips raising the above exception to generate the initial values | ||
# for the MAS context and put them in juju secret which can be picked up by pees units |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo: peer
instead of pees
amandahla
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the template for the mas configuration file. Required values used to generate the configuration file is fetched from juju secrets and charm config values at the beginning of the hooks.
Checklist
src-docs
urgent
,trivial
,complex
)