c/snap-bootstrap: split CVM related functionality in separate files #14789
+284
−203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14789 +/- ##
==========================================
- Coverage 78.95% 78.19% -0.76%
==========================================
Files 1084 1150 +66
Lines 146638 151324 +4686
==========================================
+ Hits 115773 118331 +2558
- Misses 23667 25659 +1992
- Partials 7198 7334 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pedronis
reviewed
Dec 3, 2024
| defaultCVMDisk = &disks.MockDiskMapping{ | ||
| Structure: []disks.Partition{ | ||
| seedPart, | ||
| cvmEncPart, |
There was a problem hiding this comment.
should we move cvmEncPart to this file too?
There was a problem hiding this comment.
Thanks, I missed that one. Added.
| return "signed" | ||
| } | ||
|
|
||
| func generateMountsModeRunCVM(mst *initramfsMountsState) error { |
There was a problem hiding this comment.
probably a good idea to have a doc comment attached to this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #14713 (review)