-
Notifications
You must be signed in to change notification settings - Fork 584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
many: rename registries to confdbs #14768
Conversation
b1cce0c
to
11f18d9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14768 +/- ##
==========================================
- Coverage 78.95% 78.21% -0.74%
==========================================
Files 1084 1148 +64
Lines 146638 151318 +4680
==========================================
+ Hits 115773 118352 +2579
- Misses 23667 25640 +1973
- Partials 7198 7326 +128
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! only small nitpicks
interfaces/builtin/confdb.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this warrants a change to the exclusion map in tests/main/document-interfaces-url/task.yaml
? I am confused by why it didn't fail in CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I did that in another PR that changed that test by mistake and didn't fix it here. It also didn't fail there strangely, I'm guessing that it got a 500 instead but haven't validated this yet #14777 (comment)
Signed-off-by: Miguel Pires <[email protected]>
Signed-off-by: Miguel Pires <[email protected]>
b9ba8ba
to
8a2f81e
Compare
Failures:
|
Commit 1136f37 renames the registries feature to confdbs. This includes the assertions and feature flags. So anyone who has the experimental feature enabled should unset it, refresh and then it enable it back (otherwise, change the state and exported file directly if you can do that safely). Assertions will need to be regenerated with the new assertion type.
Commit 11f18d9 pluralizes the confdb API endpoint, renaming it form /v2/confdb/... to /v2/confdbs/... which is unrelated to the previous commit but something I've been meaning to do anyway so might as well change it once