cmd/snap: expose debug validate-seed and debug seeding #14703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expose debug commands which are used by folks already. Signed-off-by: Maciej Borzecki <[email protected]>
Signed-off-by: Maciej Borzecki <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14703 +/- ##
========================================
Coverage 78.95% 78.96%
========================================
Files 1084 1085 +1
Lines 146638 147124 +486
========================================
+ Hits 115773 116171 +398
- Misses 23667 23726 +59
- Partials 7198 7227 +29
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zyga
approved these changes
Nov 8, 2024
Meulengracht
approved these changes
Nov 8, 2024
MiguelPires
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reviewing all debug commands, the all that are hidden also use
(internal)in the help message, and the ones that aren't have reasonable help messages.For clarity, the
snap debug seedingandsnap debug validate-seedare exposed since folks already use them in various contexts, so there is no point in keeping them hidden.Related: SNAPDENG-26743