tests/core/basic20plus: run for core24 #14702
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14702 +/- ##
==========================================
+ Coverage 78.95% 78.96% +0.01%
==========================================
Files 1084 1085 +1
Lines 146638 147126 +488
==========================================
+ Hits 115773 116177 +404
- Misses 23667 23723 +56
- Partials 7198 7226 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -32,23 +38,20 @@ execute: | | |||
| snap changes | MATCH "Done.*Initialize system state" | |||
|
|
|||
| echo "Check that a simple shell snap" | |||
| if os.query is-core22; then | |||
| snap install --edge "test-snapd-sh-${base_snap}" | |||
There was a problem hiding this comment.
Do you know why we used --edge?
There was a problem hiding this comment.
This was before it was pushed to stable (I.e) before the core22 base reached stable
There was a problem hiding this comment.
well, we agreed with store team to keep test snaps in edge and non listed. I think this is the main raeson
There was a problem hiding this comment.
@sergiocazzolato i don't think we are consistent in that approach today - and this snap has stable versions for all bases. What should we do? switch to edge anyway?
No description provided.