o/registrystate: add registry hook handlers #14483
Open
+608
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a change-view hook handler that checks whether the snap has rejected the changes and outputs that nicely.
Signed-off-by: Miguel Pires <[email protected]>
Signed-off-by: Miguel Pires <[email protected]>
MiguelPires
force-pushed
the
registry-hook-handlers
branch
from
c7b6c45
to
4086599
Compare
Signed-off-by: Miguel Pires <[email protected]>
Signed-off-by: Miguel Pires <[email protected]>
andrewphelpsj
approved these changes
Sep 17, 2024
pedronis
reviewed
Sep 19, 2024
Signed-off-by: Miguel Pires <[email protected]>
Signed-off-by: Miguel Pires <[email protected]>
Signed-off-by: Miguel Pires <[email protected]>
pedronis
reviewed
Sep 19, 2024
| func (h *snapHookHandler) Before() error { | ||
| return nil | ||
| } | ||
| type SnapHookHandler struct{} |
There was a problem hiding this comment.
do we need to export this now?
There was a problem hiding this comment.
The -view-changed hooks can use it. I could duplicate it but it this seemed reasonable
Signed-off-by: Miguel Pires <[email protected]>
pedronis
approved these changes
Sep 20, 2024
Comment on lines
+356
to
+357
| err = s.o.Settle(5 * time.Second) | ||
| c.Assert(err, IsNil) |
There was a problem hiding this comment.
does this bit do something?
There was a problem hiding this comment.
It just runs the manager's Ensure which is a no-op
pedronis
reviewed
Sep 20, 2024
| // prevent the next registry tasks from running before the rollbacks. Once the | ||
| // last rollback task errors, these will be put on Hold by the usual mechanism | ||
| for _, halt := range t.HaltTasks() { | ||
| halt.WaitFor(last) |
There was a problem hiding this comment.
all the run hooks will also end up with HoldStatus ?
There was a problem hiding this comment.
Once the last rollback task surfaces the error, the tasks after it will be held I believe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds registry hook handlers. The change-view- hook handler checks the transaction to see if the snap has rejected the changes (this will be done with a
snapctl fail <reason>command) and outputs that information nicely if so. The save-view- hook handler attempts to roll back previous save-view hooks that have already run if the hook failed. It saves the error, schedules rollback tasks and then outputs the error once those are done. The -view-changed doesn't have any code to it.