packaging,tests: sync patches from debian #14475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zyga
commented
Sep 18, 2024
| @@ -269,6 +269,8 @@ prepare_project() { | |||
| # no need to modify anything further for autopkgtest | |||
| # we want to run as pristine as possible | |||
| if [ "$SPREAD_BACKEND" = autopkgtest ]; then | |||
| create_test_user | |||
| systemctl enable --now snapd.socket | |||
There was a problem hiding this comment.
Debian CI still reports occasional failures. I don't quite know why but I suspect this is only partially sufficient.
Signed-off-by: Zygmunt Krynicki <[email protected]>
Signed-off-by: Zygmunt Krynicki <[email protected]>
None of the old overrides applied anymore. Signed-off-by: Zygmunt Krynicki <[email protected]>
Sudo access is managed by the "needs-sudo" flag. We can drop our custom logic and associated manipulation. This also ensures the testbed is correctly selected, and incompatible systems are rejected. Signed-off-by: Zygmunt Krynicki <[email protected]>
Internet is required to pull Go dependencies to build and install spread, as well as to download snap packages from the store. Signed-off-by: Zygmunt Krynicki <[email protected]>
The former go get command is deprecated with current Go, and no longer works correctly. Signed-off-by: Zygmunt Krynicki <[email protected]>
Spread needs to login to an account with a non-empty password. Set the password of the autopkgtest user account to the same value as the account name. Signed-off-by: Zygmunt Krynicki <[email protected]>
There is no guarantee that ID and VERSION_ID are set in /etc/os-release. Provide defaults for ID and VERSION_ID so that spread runs with _some_ system name. Spread rejects system names with two consecutive dashes, so use a special-case for unset VERSION_ID since we know it is used in a context of the Debian archive. Signed-off-by: Zygmunt Krynicki <[email protected]>
Add entries for Debian unstable "sid" to allow running the integration test suite while traversing migrations in the Debian archive. Signed-off-by: Zygmunt Krynicki <[email protected]>
Update for compatibility level 9 to 13 [1]. - remove --fail-missing from dh - remove --with=systemd from dh - drop autoreconf dependencies (obsolete since level 10) [1] https://manpages.debian.org/testing/debhelper/debhelper-compat-upgrade-checklist.7.en.html#v13 Signed-off-by: Zygmunt Krynicki <[email protected]>
The smoke test suite depends on running things as the unprivilege user "test" with the specific UID 12345. Signed-off-by: Zygmunt Krynicki <[email protected]>
For reasons I don't quite understand, and cannot reproduce when running autopkgtest locally, when the system is tested on the Debian infrastructure snapd ends up installed but not enabled. Enable the socket to at least have a chance to run something. Signed-off-by: Zygmunt Krynicki <[email protected]>
zyga
force-pushed
the
tweak/sync-from-debian-SNAPDENG-31362
branch
from
27b2c3b
to
024318d
Compare
Signed-off-by: Zygmunt Krynicki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accounts for most of the changes we have in Debian. The remaining few patches are really Debian specific or probably paper over some bugs that we should not merge here.