Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(extension): Enable Async Gunicorn workers for Flask and Django e… #747

Open
wants to merge 90 commits into
base: main
Choose a base branch
from
Open

Feat(extension): Enable Async Gunicorn workers for Flask and Django e… #747

wants to merge 90 commits into from

Conversation

alithethird
Copy link

@alithethird alithethird commented Nov 8, 2024 •
edited
Loading

Enable Async Gunicorn workers for Flask and Django extensions

Reviewers:
@jdkandersson
@javierdelapuente
@tigarmo
@gregory-schiano

  • Have you signed the CLA?

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 8, 2024
@alithethird alithethird mentioned this pull request Nov 12, 2024
Draft
jdkandersson
jdkandersson reviewed Nov 12, 2024
View reviewed changes
docs/reference/extensions/django-framework.rst Outdated Show resolved Hide resolved
rockcraft/commands/init.py Outdated Show resolved Hide resolved
tests/unit/test_cli.py Show resolved Hide resolved
docs/reference/extensions/django-framework.rst Show resolved Hide resolved
alithethird and others added 15 commits November 15, 2024 14:45
@alithethird
Merge branch 'main' into flask-django-extention-async-workers
4220cd7
@alithethird
Chore(): Update docs, update cli init test, update rockcraft.yaml f…
8d88e8c 
…ile verification
@alithethird
Merge branch 'flask-django-extention-async-workers' of github.com:ali…
fbd636c 
…thethird/rockcraft into flask-django-extention-async-workers
@alithethird
Chore(): Try to make linter happy
3280aa6
@alithethird
Chore(docs): Lint docs
c9fab57
@alithethird
Chore(docs): Update async doc link
a1df1b5
@alithethird
Merge branch 'main' into flask-django-extention-async-workers
8446f7e
@alithethird
Run CI
0ea1838
@alithethird
Merge branch 'flask-django-extention-async-workers' of github.com:ali…
a8e14d2 
…thethird/rockcraft into flask-django-extention-async-workers
@alithethird
Chore(Docs): Small doc improvements
99982f8
@alithethird
Merge branch 'main' into flask-django-extention-async-workers
a645957
@alithethird
Chore(lint): Doc lint
f35db9e
@alithethird
XMerge branch 'flask-django-extention-async-workers' of github.com:al…
b433599 
…ithethird/rockcraft into flask-django-extention-async-workers
@alithethird
Chore(docs): Add words to list
56979d4
@alithethird
Chore(): Undone import format
7c57358
@alithethird alithethird marked this pull request as ready for review November 26, 2024 09:58
jdkandersson
jdkandersson reviewed Nov 27, 2024
View reviewed changes
docs/reference/extensions/django-framework.rst Outdated Show resolved Hide resolved
docs/reference/extensions/django-framework.rst Outdated Show resolved Hide resolved
docs/reference/extensions/django-framework.rst Outdated Show resolved Hide resolved
docs/reference/extensions/flask-framework.rst Outdated Show resolved Hide resolved
rockcraft/commands/init.py Outdated Show resolved Hide resolved
rockcraft/commands/init.py Outdated Show resolved Hide resolved
jdkandersson
jdkandersson reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@jdkandersson jdkandersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still need to discuss re a spread test for async

docs/reference/extensions/django-framework.rst Outdated Show resolved Hide resolved
rockcraft/commands/init.py Outdated Show resolved Hide resolved
tests/unit/test_cli.py Outdated Show resolved Hide resolved
tigarmo
tigarmo requested changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thankss

docs/reference/extensions/django-framework.rst Outdated Show resolved Hide resolved
docs/reference/extensions/flask-framework.rst Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
spread.yaml Outdated Show resolved Hide resolved
tests/unit/test_cli.py Show resolved Hide resolved
tests/unit/extensions/test_gunicorn.py Outdated Show resolved Hide resolved
@tigarmo
Copy link
Collaborator

tigarmo commented Dec 9, 2024

Readthedocs errors:

<generated text>:3: ERROR: Unexpected indentation.
<generated text>:3: ERROR: Unexpected indentation.
/home/docs/checkouts/readthedocs.org/user_builds/canonical-rockcraft/checkouts/747/docs/reference/extensions/flask-framework.rst:52: WARNING: duplicate label async-gunicorn-workers, other instance in /home/docs/checkouts/readthedocs.org/user_builds/canonical-rockcraft/checkouts/747/docs/reference/extensions/django-framework.rst

tigarmo
tigarmo requested changes Dec 10, 2024
View reviewed changes
tests/unit/extensions/test_gunicorn.py Outdated Show resolved Hide resolved
tests/unit/extensions/test_gunicorn.py Outdated Show resolved Hide resolved
@tigarmo tigarmo requested a review from medubelko December 10, 2024 12:53
tigarmo
tigarmo approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@tigarmo tigarmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! @medubelko can you take a look at the updated docs and give the second review?

tests/unit/extensions/test_gunicorn.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javierdelapuente javierdelapuente javierdelapuente left review comments

@jdkandersson jdkandersson jdkandersson approved these changes

@erinecon erinecon erinecon approved these changes

@tigarmo tigarmo tigarmo approved these changes

@medubelko medubelko Awaiting requested review from medubelko

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alithethird @tigarmo @javierdelapuente @erinecon @jdkandersson