Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Vale styles to fix Kafka-k8s docs false positive results #69

Merged
merged 8 commits into from
Aug 8, 2024

Conversation

izmalk
Copy link
Contributor

@izmalk izmalk commented Aug 1, 2024

These suggestions are based on fixing false positive results of Vale tests for Kafka-k8s charmed operator documentation.

@izmalk izmalk self-assigned this Aug 1, 2024
@izmalk izmalk marked this pull request as draft August 1, 2024 18:59
izmalk added 2 commits August 1, 2024 20:09
Remove redundant changes that can't be justified by the main goal: repo is not a contraction and updating error messages is out of scope for this PR.
@izmalk izmalk changed the title Suggestions to Style guide to fix false positive in Kafka docs Vale tests Updating Vale styles to fix false positive results Aug 1, 2024
@izmalk izmalk changed the title Updating Vale styles to fix false positive results Updating Vale styles to fix Kafka-k8s docs false positive results Aug 1, 2024
@izmalk izmalk marked this pull request as ready for review August 1, 2024 20:00
@izmalk izmalk requested review from evilnick and SecondSkoll August 1, 2024 20:00
@evilnick
Copy link
Contributor

evilnick commented Aug 8, 2024

I'm happy with adding extra issues for any more tweaks required to this, would be good to land the useful bits

evilnick
evilnick previously approved these changes Aug 8, 2024
@izmalk izmalk merged commit 0c5f222 into canonical:main Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants