Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB ROCK #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

MiaAltieri
Copy link

Ping the @canonical/rocks team.


Description

This PR adds the charmed-mongodb-rock to the factory.


Picture of a cool ROCK:
Screenshot 2023-09-01 at 17 37 56

Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is indeed a cool ROCK 😎

While we wait for the PR checks and reviews, since this is a new ROCK that you're trying to publish onto the ubuntu namespaces, can you please complete the onboarding process? You can simply raise a new issue. The one thing I believe might raise some questions is the ROCK name prefix charmed- instead of just mongodb, but we'll cover that in your issue

@MiaAltieri
Copy link
Author

@cjdcordeiro thanks for the help here! 😄 I just completed the onboarding process :)

As for naming, unfortunately it must be named charmed-mongodb, due to MongoDB's strict usage guidelines. This is why everything in the Canonical MongoDB sphere is prefixed with charmed, i.e. Charmed MongoDB Snap, Charmed MongoDB-K8s, Charmed MongoDB Operator

@cjdcordeiro cjdcordeiro force-pushed the main branch 19 times, most recently from 6773854 to fbad11c Compare September 12, 2023 08:19
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update: BLOCKED, waiting on #54. The tests are also failing.

@clay-lake
Copy link
Contributor

Hey @cjdcordeiro, Should we get this rock merged into oci-factory?

@cjdcordeiro cjdcordeiro requested a review from a team as a code owner September 26, 2024 08:06
@cjdcordeiro
Copy link
Collaborator

#54 is still open and the tests were failing (just rebased it). So we need to check with @MiaAltieri ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants