Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add metrics-proxy rock #267

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: Add metrics-proxy rock #267

wants to merge 5 commits into from

Conversation

IbraAoad
Copy link

@IbraAoad IbraAoad commented Oct 17, 2024 •
edited
Loading

Ping the @canonical/rocks team.

Description

This PR adds the metrics-proxy ROCK to the OCI factory.

Related issues

#268

Picture of a cool rock:
cool-rock

@IbraAoad IbraAoad marked this pull request as ready for review October 17, 2024 13:16
@IbraAoad IbraAoad requested a review from a team as a code owner October 17, 2024 13:16
@IbraAoad IbraAoad changed the title [WIP] feat: Add metrics-proxy rock feat: Add metrics-proxy rock Oct 17, 2024
@IbraAoad
Copy link
Author

IbraAoad commented Dec 3, 2024

@cjdcordeiro Do you mind taking a look at this as well, thanks! 🙇‍♂️

cjdcordeiro
cjdcordeiro approved these changes Dec 3, 2024
View reviewed changes
Copy link
Collaborator

@cjdcordeiro cjdcordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It lgtm. Thanks. Since it's the 1st PR, I'd also like another colleague to have a 2nd look before merging

FYI @clay-lake @zhijie-yang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjdcordeiro cjdcordeiro cjdcordeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IbraAoad @cjdcordeiro