Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor image vault utils #3846

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Replace `auto _` with `std::ignore`

f128abb
Select commit
Loading
Failed to load commit list.
Open

Refactor image vault utils #3846

Replace `auto _` with `std::ignore`
f128abb
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 17, 2024 in 0s

89.02% (+0.07%) compared to a516c93

View this Pull Request on Codecov

89.02% (+0.07%) compared to a516c93

Details

Codecov Report

Attention: Patch coverage is 86.56716% with 9 lines in your changes missing coverage. Please review.

Project coverage is 89.02%. Comparing base (a516c93) to head (f128abb).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/platform/backends/lxd/lxd_vm_image_vault.cpp 50.00% 4 Missing ⚠️
src/xz_decoder/xz_image_decoder.cpp 0.00% 3 Missing ⚠️
src/daemon/default_vm_image_vault.cpp 81.81% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3846      +/-   ##
==========================================
+ Coverage   88.94%   89.02%   +0.07%     
==========================================
  Files         256      257       +1     
  Lines       14584    14593       +9     
==========================================
+ Hits        12972    12991      +19     
+ Misses       1612     1602      -10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov