Escape mount sources and targets #3828
Open
+20
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3828 +/- ##
==========================================
- Coverage 88.94% 88.94% -0.01%
==========================================
Files 256 256
Lines 14584 14580 -4
==========================================
- Hits 12972 12968 -4
Misses 1612 1612 ☔ View full report in Codecov by Sentry. |
andrei-toterman
approved these changes
Dec 13, 2024
sharder996
approved these changes
Dec 17, 2024
Any commits made after this event will not be merged.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Any commits made after this event will not be merged.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 18, 2024
Escape mount sources and targets
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3759
Previously, mount targets and sources were not escaped. This caused strange targets and mounts like
" & mkdir hello & "to be able to execute commands in the instance. Now they are properly escaped so strangely named directories like" & mkdir hello & "will work as source or target.MULTI-1675