Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change file permissions on instances #3715

Draft
wants to merge 12 commits into
base: fix-platform-specific-functions-in-abstraction
Choose a base branch
from

Readd permission setting to new files/folders

73f969e
Select commit
Loading
Failed to load commit list.
Draft

Change file permissions on instances #3715

Readd permission setting to new files/folders
73f969e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 18, 2024 in 1s

88.93% (+0.00%) compared to a5015cd

View this Pull Request on Codecov

88.93% (+0.00%) compared to a5015cd

Details

Codecov Report

Attention: Patch coverage is 89.58333% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.93%. Comparing base (a5015cd) to head (73f969e).

Files with missing lines Patch % Lines
src/platform/platform_unix.cpp 0.00% 2 Missing ⚠️
src/utils/permission_utils.cpp 94.44% 2 Missing ⚠️
src/utils/vm_image_vault_utils.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                               Coverage Diff                               @@
##           fix-platform-specific-functions-in-abstraction    #3715   +/-   ##
===============================================================================
  Coverage                                           88.93%   88.93%           
===============================================================================
  Files                                                 256      257    +1     
  Lines                                               14571    14617   +46     
===============================================================================
+ Hits                                                12959    13000   +41     
- Misses                                               1612     1617    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.