Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount targets are not validated #3759

Open
Sploder12 opened this issue Oct 29, 2024 · 0 comments · May be fixed by #3828
Open

Mount targets are not validated #3759

Sploder12 opened this issue Oct 29, 2024 · 0 comments · May be fixed by #3828
Labels
bug high high importance jira Create a Jira ticket for this issue medium medium importance

Comments

@Sploder12
Copy link
Contributor

Describe the bug
The mount target is not checked/validated to be a valid path. This allows for interesting targets to be used.

To Reproduce

  1. launch multipass GUI
  2. create a mount with a valid source but invalid target such as " & mkdir hello & "
  3. observe mount fails for some reason, that may not be "bad mount point"
  4. shell into the instance
  5. observe ~/hello exists

Also works in CLI but less interesting.

Expected behavior
The daemon prevents the usage of such targets without allowing side effects.

Additional context
Mount source is verified to be an existing file but, it might make sense to also validate the source as well. Windows paths are important to consider for both source and target since C:\foo\ is a valid path.

@Sploder12 Sploder12 added bug needs triage Issue needs to be triaged labels Oct 29, 2024
@ricab ricab added high high importance medium medium importance and removed needs triage Issue needs to be triaged labels Nov 15, 2024
@Sploder12 Sploder12 added the jira Create a Jira ticket for this issue label Nov 29, 2024
@Sploder12 Sploder12 linked a pull request Dec 9, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug high high importance jira Create a Jira ticket for this issue medium medium importance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants