Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Images Workflow Improvement #4791

Merged
merged 8 commits into from
Dec 18, 2024
Merged

Conversation

louiseschmidtgen
Copy link
Contributor

Update Images Workflow Improvement

This PR accomplishes the following:

Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, minor comment

@@ -14,11 +18,13 @@ jobs:
# Latest branches
- { branch: master, channel: latest/edge }
# Stable branches
- { branch: "1.31", channel: "1.31" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should also add 1.32?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, once we have release branches.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, my mind was stuck in the k8s-snap universe. Ignore my comment...

@@ -37,7 +43,7 @@ jobs:
commit-message: update list of images used by ${{ matrix.channel }}
title: "[${{ matrix.channel }}] Update MicroK8s images"
body: update list of images used by ${{ matrix.channel }}
reviewers: neoaggelos,ktsakalozos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:(

@louiseschmidtgen louiseschmidtgen merged commit 2d42617 into master Dec 18, 2024
12 checks passed
@louiseschmidtgen louiseschmidtgen deleted the KU-2335/workflow-reviewers branch December 18, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants