-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Images Workflow Improvement #4791
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, minor comment
@@ -14,11 +18,13 @@ jobs: | |||
# Latest branches | |||
- { branch: master, channel: latest/edge } | |||
# Stable branches | |||
- { branch: "1.31", channel: "1.31" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should also add 1.32?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, once we have release branches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, my mind was stuck in the k8s-snap universe. Ignore my comment...
@@ -37,7 +43,7 @@ jobs: | |||
commit-message: update list of images used by ${{ matrix.channel }} | |||
title: "[${{ matrix.channel }}] Update MicroK8s images" | |||
body: update list of images used by ${{ matrix.channel }} | |||
reviewers: neoaggelos,ktsakalozos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:(
Update Images Workflow Improvement
This PR accomplishes the following: