fix(login): Fixed User desktop login failure after the.Xauthority file permission or authname is modified #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
| @@ -294,7 +294,8 @@ x_authority_write (XAuthority *auth, XAuthWriteMode mode, const gchar *filename, | |||
| if (!matched && | |||
| priv->family == a_priv->family && | |||
| address_matches && | |||
| strcmp (priv->number, a_priv->number) == 0) | |||
| strcmp (priv->number, a_priv->number) == 0 && | |||
| strcmp (priv->authorization_name, a_priv->authorization_name) == 0) | |||
There was a problem hiding this comment.
This change looks good, but it unrelated to the above change - can you do these as two separate PRs?
There was a problem hiding this comment.
Okay, I will resubmit the PR separately. Thank you！
src/session-child.c
Outdated
| privileges_drop (user_get_uid (user), user_get_gid (user)); | ||
| if (x_authority_filename && chmod (x_authority_filename, S_IRUSR | S_IWUSR) < 0) |
There was a problem hiding this comment.
The chmod should be in x-authority.c I think - that's where it is set for newly created files.
There was a problem hiding this comment.
In the actual application process, an old file was accidentally modified with permissions, resulting in the inability to start a user session. This is done to remedy this abnormal situation.
|
Everyone contributing to this PR have now signed the CLA. Thanks! |
…ority file's authname is modified Description: 修复用户的.Xauthority文件的authname被修改后无法登录用户桌面问题 Log: null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed User desktop login failure after the.Xauthority file permission or authname is modified
Description: 修复用户的.Xauthority文件权限或authname被修改后无法登录用户桌面问题
Log: null