Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review kubernetes auth token RPC #854

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

HomayoonAlimohammadi
Copy link
Contributor

Needs canonical/k8s-snap-api#21

Overview

This PR replaces the literal string with ReviewKubernetesAuthTokenRPC from k8s-snap-api.

@HomayoonAlimohammadi HomayoonAlimohammadi requested a review from a team as a code owner November 28, 2024 12:00
Copy link
Contributor

@bschimke95 bschimke95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HomayoonAlimohammadi HomayoonAlimohammadi merged commit bb2be37 into main Dec 4, 2024
18 checks passed
@HomayoonAlimohammadi HomayoonAlimohammadi deleted the KU-2212/add-review-token-rpc branch December 4, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants