CSS-4739 Removes the dashboard resource. #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIMM will no longer be serving the dashboard files since we have a juju dashboard charm.
alesstimec
changed the title
babakks
approved these changes
Jul 11, 2023
kian99
approved these changes
Jul 11, 2023
babakks
approved these changes
Jul 11, 2023
| @@ -40,126 +32,8 @@ func Handler(ctx context.Context, loc string, publicDNSname string) http.Handler | |||
| } | |||
| if u != nil && u.IsAbs() { | |||
| mux.Handle(dashboardPath, http.RedirectHandler(loc, http.StatusPermanentRedirect)) | |||
| return mux | |||
| } else { | |||
| zapctx.Warn(ctx, "not redirecting to the dashboard", zap.String("dashboard_location", loc)) | |||
There was a problem hiding this comment.
Now that we don't serve local files, what happens when we get a relative path? It seems we do nothing here.
ale8k
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
JIMM will no longer be serving the dashboard files since we have a juju dashboard charm that serves the dashboard. The other alternative is for JIMM to redirect the user to the location that serves the dashboard.
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers