General fixes after QA #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
force-pushed
the
general-fixes-after-qa-01
branch
from
289f36d
to
f50d769
Compare
kian99
approved these changes
Jul 7, 2023
| for i := range dbCloud.Regions { | ||
| dbCloud.Regions[i].Controllers = []dbmodel.CloudRegionControllerPriority{{ | ||
| ControllerID: region.Controllers[0].ID, | ||
| Priority: dbmodel.CloudRegionControllerPrioritySupported, | ||
| ControllerID: controller.ID, |
There was a problem hiding this comment.
This feels significant, can you explain what it was doing and why it's changing?
There was a problem hiding this comment.
because this never worked.. notice line 395, where we get information from the controller on the added cloud.. well.. that information does not contain the controller ID.. and this update was failing due to foreign key constraints
| @@ -85,6 +85,7 @@ func Handler(ctx context.Context, loc string) http.Handler { | |||
| continue | |||
| } | |||
| var w bytes.Buffer | |||
| configParams["baseControllerURL"] = publicDNSname | |||
There was a problem hiding this comment.
we weren't rendering the config.js properly.. the controller url was set to None due to a bug in the dashboard and jimm
alesstimec
force-pushed
the
general-fixes-after-qa-01
branch
from
f50d769
to
cb12ffb
Compare
- fix for the dashboard relation: keys using _ instead of - - properly rendering config.js for the dashboard
alesstimec
force-pushed
the
general-fixes-after-qa-01
branch
from
cb12ffb
to
afd1613
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers