Charms update openfga library 01 #986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Charm now persists vault data in unit state and ensures the file is pushed to the workload container on every update.
|
I see this is failing to build the machine charm, is #987 present in this PR? |
alesstimec
force-pushed
the
charms-update-openfga-library-01
branch
3 times, most recently
from
51cacb1
to
a30b6bb
Compare
And a minor fix for required settings that will now display a sensible message to the user.
alesstimec
force-pushed
the
charms-update-openfga-library-01
branch
from
a30b6bb
to
00e056a
Compare
kian99
approved these changes
Jul 7, 2023
| charm-python-packages: | ||
| - setuptools | ||
| - cosl | ||
| - pydantic==1.10 |
There was a problem hiding this comment.
Ah this is going into feature-rebac and these lines were already added to main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers