Tweaked workflows #970
Merged
Tweaked workflows #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
force-pushed
the
test-tweaked-workflows
branch
from
a8191db
to
46842cd
Compare
kian99
force-pushed
the
test-tweaked-workflows
branch
from
46842cd
to
f7ca5bb
Compare
This reverts commit b8282f2.
kian99
requested review from
alesstimec and
ale8k
and removed request for
alesstimec
alesstimec
approved these changes
Jul 19, 2023
ale8k
reviewed
Jul 19, 2023
| @@ -27,25 +29,14 @@ jobs: | |||
| runs-on: ubuntu-20.04 | |||
| steps: | |||
| - uses: actions/checkout@v3 | |||
| - uses: ./.github/workflows/setupgo118amd64 | |||
| - uses: actions/setup-go@v4 | |||
ale8k
reviewed
Jul 19, 2023
| - name: Install dependencies | ||
| run: sudo apt-get update -y && sudo apt-get install -y gcc git-core gnupg build-essential | ||
| - name: Remove installed mongodb | ||
| run: sudo apt purge mongodb-org && sudo apt autoremove | ||
| - run: sudo snap install juju-db --channel 4.4/stable | ||
| - name: Pull candid repo for test environment |
There was a problem hiding this comment.
The tests don't use it
There was a problem hiding this comment.
It saves us 2 minutes on each run now
There was a problem hiding this comment.
Ah I'm with you, we use a test candid, I think I left this here in hopes we would run acceptance tests eventually though...
ale8k
approved these changes
Jul 19, 2023
@ale8k For the BDD tests we would need it but not these tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing some changes to the workflows and am finally happy with it. The full changes for this PR are as below.
devprofile because they do not play a part in testing.