Css 4587 backport generic fixes #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
commented
Jun 26, 2023
|
|
||
| > Any changes made inside the repo will automatically restart the JIMM server via a volume mount. So there's no need | ||
| to re-run the compose continuously, but note, if you do bring the compose down, remove the volumes otherwise | ||
| vault will not behave correctly, this can be done via `docker compose down -v` | ||
|
|
||
| If all was successful, you should seen an output similar to: | ||
| ``` | ||
| NAME COMMAND SERVICE STATUS PORTS |
There was a problem hiding this comment.
I removed this because it felt unnecessary to show in the readme and just made it longer and harder to scan for the section you need.
There was a problem hiding this comment.
Yeah fair, it was a bit too "full" i agree
| exec /root/candidsrv /etc/candid/config.yaml |
There was a problem hiding this comment.
This now ensures candid immediately exits when you kill the compose because the shell isn't running Candid as a background job.
There was a problem hiding this comment.
Yeah sounds good to me, what would be better is a proper compose healthcheck ideally though
There was a problem hiding this comment.
This is a new script I added that automates the setup of the juju controller. We should bring these improvements to feature-rebac too.
ale8k
approved these changes
Jun 26, 2023
babakks
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR backports all the work done on
feature-rebacto enable JIMM to work in a local setup with docker compose and a locally deployed Juju controller.It also backports some minor fixes to the snapcraft.yaml file for JIMM and other miscellaneous fixes.
Engineering checklist
Check only items that apply