Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Juju 7058/fix pagination for entitlement #1435

Open
wants to merge 3 commits into
base: v3
Choose a base branch
from

Conversation

SimoneDutto
Copy link
Contributor

Description

In this PR we change the way we return pages of entries from OpenFGA.
Before, we returned a page containing only one entity kind, which caused confusion to users because if they asked for a pageSize 10 and we returned a pageSize 5 with a continuation token, they would assume there weren't more entries.

Now we try to fill the page of pageSize entries, independently of entity kind.

the second-page fetch of pageSize is to ensure that if we return a continuation token, there are at least one more entry in openfga.

Address #1419

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

@SimoneDutto SimoneDutto requested a review from a team as a code owner November 14, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant