Juju 7058/fix pagination for entitlement #1435
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we change the way we return pages of entries from OpenFGA.
Before, we returned a page containing only one entity kind, which caused confusion to users because if they asked for a
pageSize
10 and we returned apageSize
5 with a continuation token, they would assume there weren't more entries.Now we try to fill the page of
pageSize
entries, independently of entity kind.Address #1419
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers