Juju 7074/identities filter #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimoneDutto
force-pushed
the
JUJU-7074/identities-filter
branch
from
b79f490
to
10cd635
Compare
kian99
approved these changes
Nov 13, 2024
ale8k
requested changes
Nov 15, 2024
| const op = errors.Op("jimm.ListIdentities") | ||
|
|
||
| if !user.JimmAdmin { | ||
| return nil, errors.E(op, errors.CodeUnauthorized, "unauthorized") | ||
| } | ||
| identities, err := j.Database.ListIdentities(ctx, pagination.Limit(), pagination.Offset(), match) | ||
| var users []openfga.User |
There was a problem hiding this comment.
Feel like I'm reading that book aha. Love it.
internal/jimm/identity_test.go
Outdated
| limit: 5, | ||
| offset: 0, | ||
| identities: []string{userNames[0]}, | ||
| match: userNames[0][:5], |
There was a problem hiding this comment.
As we're reating another slice anyway rather than just [:1], either do: [:1] on 117 or hardcode the string in please.
I'm usually of the preference of hardcoding strings in tests as I feel like it makes them more readable rather than bob1->5. Also as this is a match, doing [0] and [:5] against a string is less readable (imo) than just getting "bob1".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds filtering for rebac
listIdentitieson group name/id.Address #1421
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers