change use of group parameter for PatchIdentityGroups #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The group parameter passed to the PatchIdentityGroups method is a group ID not a group tag (not group-ID and instead just ID). This PR fixes that misinterpretation.
kian99
changed the title
ale8k
approved these changes
Nov 8, 2024
alesstimec
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The group parameter passed to the PatchIdentityGroups method is a group ID not a group tag (i.e. not
group-IDand instead justID). This PR fixes that misinterpretation and fixes the issue that a user's groups couldn't be updated.Fixes #1420
Fixes JUJU-7056
Engineering checklist
Check only items that apply