Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gorm test logger #1417

Merged
merged 6 commits into from
Nov 5, 2024
Merged

gorm test logger #1417

merged 6 commits into from
Nov 5, 2024

Conversation

SimoneDutto
Copy link
Contributor

Description

This pr sets the gorm logger for tests.
By default they are disabled, but you can enable them via env variable or via an enable/disable methods.

Fixes JIRA/GitHub issue number

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Test instructions

Notes for code reviewers

@SimoneDutto SimoneDutto requested a review from a team as a code owner October 29, 2024 08:51
@ale8k
Copy link
Contributor

ale8k commented Nov 1, 2024

test

internal/db/group_test.go Outdated Show resolved Hide resolved
Copy link
Contributor

@kian99 kian99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good with 2 comments.

internal/db/db.go Outdated Show resolved Hide resolved
internal/db/group_test.go Outdated Show resolved Hide resolved
kian99
kian99 previously approved these changes Nov 1, 2024
Copy link
Contributor

@kian99 kian99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add documentation on this in CONTRIBUTING.md

Copy link
Contributor

@ale8k ale8k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SimoneDutto SimoneDutto merged commit 152d43c into canonical:v3 Nov 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants