fix panic when connection to controller fails #1415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr fixes a bug that causes Jimm to panic when it is issued
juju status
on a not-existing model.How to reproduce the bug
qa-microk8s
make dev-env-cleanup
andmake dev-env
again)juju status
Jimm will panic. It can't find the model in the database, so it is not able to create the connection. Therefore, it will later try to read Json from a nil connection.
This fix returns the error and adds a test for it.
Before the fix
and juju status hangs
After the fix
juju status will return
ERROR model not found (not found)
Fixes JIRA/GitHub issue number
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers