Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get group by name #1378

Merged
merged 8 commits into from
Oct 1, 2024
Merged

Get group by name #1378

merged 8 commits into from
Oct 1, 2024

Conversation

pkulik0
Copy link
Contributor

@pkulik0 pkulik0 commented Sep 26, 2024

Description

This PR makes it possible to fetch groups by name using the GetGroup endpoint. This change is required for the jaas group data source of the juju terraform provider.

CSS-10995

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

@pkulik0 pkulik0 requested a review from a team as a code owner September 26, 2024 12:56
internal/jimm/access.go Outdated Show resolved Hide resolved
@pkulik0 pkulik0 requested review from kian99, alesstimec and a team September 27, 2024 15:12
}

// GetGroupByUUID returns a group based on the provided UUID.
func (j *JIMM) GetGroupByUUID(ctx context.Context, user *openfga.User, uuid string) (*dbmodel.GroupEntry, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

internal/jujuapi/jimm.go Outdated Show resolved Hide resolved
internal/jimm/access.go Show resolved Hide resolved
internal/jimm/access_test.go Show resolved Hide resolved
@pkulik0 pkulik0 requested a review from kian99 September 27, 2024 15:51
kian99
kian99 previously approved these changes Sep 30, 2024
Copy link
Contributor

@kian99 kian99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with some minor comments

pkg/api/client.go Outdated Show resolved Hide resolved
internal/jujuapi/access_control_test.go Show resolved Hide resolved
@pkulik0 pkulik0 merged commit 07af23c into canonical:v3 Oct 1, 2024
4 checks passed
@pkulik0 pkulik0 deleted the get-group-by-name branch October 1, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants