Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicated appoffer tag #1374

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

kian99
Copy link
Contributor

@kian99 kian99 commented Sep 20, 2024

Description

This PR removes the applicationOffer tag from Jimm. The same tag with the same parsing logic already existed in Juju so we can use that instead.

@kian99 kian99 requested a review from a team as a code owner September 20, 2024 07:50
Copy link
Collaborator

@alesstimec alesstimec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (XXS)

@kian99 kian99 merged commit dc065a3 into canonical:v3 Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants