Merge v3 into feature-http-proxy #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-server Css 9387 add rebac admin backend server
* add entitlements api to rebac endpoint * update embed file names
…h handler + change its test
* WIP * Add handler for rebac group service add constructor for entitlement service * Update godoc * Pass JIMM to rebac_admin
Merge v3 rebac
* Add pagination to list groups method * Moved common package and made pagination package
* refactor jimm relations methods * rename parseTag to parseAndResolveTag
CSS 9386 authentication middleware
* Avoid use of DB outside of jimm * test fixes Replace hardcoded controller UUID in tests with constant * Export ControllerService Drive-by warning fix * minor refactoring * avoid returning a params type from jimm layer Rather than returning an apiParams type from the jimm layer in `ControllerInfo`, return a dbmodel. This also means it doesn't make sense to return the JIMM controller info since that is not a entity stored in the database. The construction of the JIMM controller info is kept directly in `jujuapi`. * update godocs
* implement GetGroupEntitlements * test fixes * address PR comments - More descriptive names - Minor tweaks to function signatures * add missing copyright lines * refactor functions to handle application logic at jimm layer * use concrete type in jimm layer rather than a string * revert move of function * added missing godocs/copyright and test fix
* implement patch group entitlements * minor change in creating error response * address follow-up comments from previous PR * PR comments
* add get identities entitlements * add patch identity entitlements
Merge v3 feature rebac admin
- Remove old invalid doc - Add more info to charm folder
* add cors middleware - fix bug with cookies differing when calling login and whoami endpoints * set httpOnly to true on cookies * add test that CORS is enabled correctly
* resources endpoint
Merge v3 feature rebac admin
* cleanup logging in model proxy * simplify model proxy - Simplified the model proxy to remove the need for a mutex. - Handle an edge case in the model proxy where if the controller routine returned we don't stop the proxy. * catch specific errors on websocket read
Merge v3 feature rebac admin
Feature rebac admin
kian99
requested review from
alesstimec,
SimoneDutto,
babakks,
ale8k and
pkulik0
SimoneDutto
approved these changes
Sep 5, 2024
pkulik0
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge branch
v3intofeature-http-proxy.