Merge v3 feature rebac admin #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use specific lxd version when building JIMM Rock
- Remove old invalid doc - Add more info to charm folder
* add cors middleware - fix bug with cookies differing when calling login and whoami endpoints * set httpOnly to true on cookies * add test that CORS is enabled correctly
kian99
requested review from
alesstimec,
SimoneDutto,
babakks,
ale8k and
pkulik0
SimoneDutto
approved these changes
Sep 4, 2024
pkulik0
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge
v3into feature-rebac admin.Also fixed a missing docstring.