Eliminate the need for TLS certs in tests #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
force-pushed
the
tweak-cmd-tests
branch
from
05ba0c8
to
c974260
Compare
ale8k
previously approved these changes
Aug 28, 2024
SimoneDutto
reviewed
Aug 28, 2024
SimoneDutto
approved these changes
Aug 28, 2024
babakks
approved these changes
Aug 28, 2024
kian99
added a commit
to kian99/jimm
that referenced
this pull request
Sep 3, 2024
* eliminate the need for TLS certs in tests * remove InsecureSkipVerify config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the jimmctl and jaas cmd tests to eliminate the need to setup the JIMM server with TLS certs.
Although the Juju API client hardcodes its connection to the controller with
wss://to enforce secure websockets, it does provide the ability to inject a custom websocket dialer.In our tests, we provide a custom websocket dialer where we replace the
wss://in the host address withws://to allow JIMM to be run as a plain HTTP server.I've also updated our CI workflow to remove the step where it was setting up certs and additionally removed the environment variables we were setting that were not needed.
Big thanks to @ale8k for the suggestion on using a custom dialer.
Engineering checklist
Check only items that apply