Improve Terraform Provider integration testing #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
changed the title
ale8k
approved these changes
Aug 28, 2024
| @@ -37,7 +37,7 @@ services: | |||
| JIMM_OAUTH_CLIENT_SECRET: "SwjDofnbDzJDm9iyfUhEp67FfUFMY8L4" | |||
| JIMM_OAUTH_SCOPES: "openid profile email" # Space separated list of scopes | |||
| JIMM_DASHBOARD_FINAL_REDIRECT_URL: "https://jaas.ai" # Example URL | |||
| JIMM_ACCESS_TOKEN_EXPIRY_DURATION: 1h | |||
| JIMM_ACCESS_TOKEN_EXPIRY_DURATION: 100h | |||
There was a problem hiding this comment.
To make local dev less tedious, you don't need to repeatedly login.
| @@ -44,7 +44,7 @@ func (d *cacheDialer) Dial(ctx context.Context, ctl *dbmodel.Controller, mt name | |||
| return d.dialer.Dial(ctx, ctl, mt, requiredPermissions) | |||
| } | |||
| rc := d.sfg.DoChan(ctl.Name, func() (interface{}, error) { | |||
| return d.dial(ctx, ctl) | |||
| return d.dial(ctx, ctl, requiredPermissions) | |||
There was a problem hiding this comment.
How did this work before without the permissions?
There was a problem hiding this comment.
There are default permissions set in the dialer so that probably resolves most issues because we don't add extra permissions in many places, and I believe the cache dialer is not used unless actually running JIMM?
We also probably want to get rid of the cache dialer, but this is still better than before.
There was a problem hiding this comment.
I think I need to look over the default permissions, never really fully understood the permission map and what goes where... But oki thank you!
pkulik0
approved these changes
Aug 28, 2024
kian99
added a commit
to kian99/jimm
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes some tweaks after testing JIMM with the Juju Terraform Provider. The changes of note are:
GetApplicationOfferConsumeDetailsto exclude the user field which currently causes an unknown error.Partially addresses CSS-6347
Engineering checklist
Check only items that apply