Use more descriptive error messages in model proxy #1320
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue in tests that were checking the error from
ProxySockets
.The model proxy returns an error once the proxy is completed but there are actually 2 errors emitted, 1 from the client side connection and 1 from the controller side connection, because only the first of the two errors is returned there is a sort of race in which message the calling function sees.
We fix this by using more descriptive error messages in the model proxy and then using an appropriate regex in tests.
Debugging the race condition was made easy by running the tests with a high count, so running the following:
go test -timeout 30s -run ^TestProxySocketsAuditLogs$ github.com/canonical/jimm/v3/internal/rpc -count=1000
surfaced the issue consistently
Engineering checklist
Check only items that apply