golangci-lint #1319
Merged
golangci-lint #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
reviewed
Aug 19, 2024
kian99
previously approved these changes
Aug 21, 2024
| @@ -9,7 +9,7 @@ run: | |||
| tests: true | |||
| allow-parallel-runners: false | |||
| allow-serial-runners: false | |||
| # go: "1.17" # Do not set a go limit | |||
| # go: "1.23" | |||
There was a problem hiding this comment.
Should this comment stick around?
There was a problem hiding this comment.
Don't think it does any harm really
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: stable | ||
| cache: false |
There was a problem hiding this comment.
I suppose we can try turn this on in a follow-up PR and see what effect it has?
kian99
reviewed
Aug 21, 2024
kian99
approved these changes
Aug 21, 2024
alesstimec
approved these changes
Aug 21, 2024
kian99
pushed a commit
to kian99/jimm
that referenced
this pull request
Sep 3, 2024
* golangci-lint * test linter with err * will this work? * perhaps it is working? * try a 5 min timeout with verbose... * 10m no critic * try a bump * wip * reference field directly? * tmate * bump jimm? * approle * . * int overflows. * rename * extra newline * add linting to make * make target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces golangci-lint action. Now all of JIMM's linting issues have been fixes. This should pass.
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers