Add test for ParseRelation function #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure all valid relation strings can be parsed to a relation type
ale8k
reviewed
Sep 29, 2023
internal/openfga/names/names.go
Outdated
| @@ -36,6 +38,10 @@ var ( | |||
| NoRelation cofga.Relation = "" | |||
| ) | |||
|
|
|||
| // AllRelations contains a slice of all valid relations. | |||
| // NB: Add any new relations from the above to this slice. | |||
| var AllRelations = []cofga.Relation{MemberRelation, AdministratorRelation, ControllerRelation, ModelRelation, ConsumerRelation, ReaderRelation, WriterRelation, CanAddModelRelation, AuditLogViewerRelation, NoRelation} | |||
There was a problem hiding this comment.
Is this only used in the test?
There was a problem hiding this comment.
Yeah it is, do you want me to make it unexported?
There was a problem hiding this comment.
Yeah, it's best to keep it just visible for the test files.
babakks
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently a command like
./jimmctl auth relation check user-kian-parvin@external audit_log_viewer controller-jimmfails with the errorERROR unknown relation (failed to parse tuple object key)because theaudit_log_viewerrelation wasn't added to the ParseRelation function.Added a test to make sure we can catch this in the future, and found we also didn't have the
controllerandmodelrelation strings mapped (possibly intentionally? though I don't see why).Engineering checklist
Check only items that apply