CSS-5672 Adds declared caveats to the discharge macaroon. #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesstimec
changed the title
kian99
approved these changes
Sep 22, 2023
|
|
||
| if allowed { | ||
| return []checkers.Caveat{ | ||
| checkers.DeclaredCaveat(relationString, objectTagString), |
There was a problem hiding this comment.
This is the main bit that changed right?
| c.Check(ms, qt.HasLen, 2) | ||
| c.Assert(ms, qt.HasLen, 2) | ||
|
|
||
| declaredCaveats := checkers.InferDeclared(macaroon.MacaroonNamespace, ms) |
There was a problem hiding this comment.
Out of interest is this a mock checker that will always validate the caveat or something? Or where do we setup the permissions for the test.
There was a problem hiding this comment.
Oh nvm, I see the setup function in all the tests is how that's done.
ale8k
reviewed
Sep 22, 2023
| jimmnames "github.com/canonical/jimm/pkg/names" | ||
| ) | ||
|
|
||
| var defaultDischargeExpiry = 15 * time.Minute |
There was a problem hiding this comment.
Much better having these functions moved out
ale8k
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds declared caveats to the discharge macaroon.
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers