Better logging in model proxy and macaroon discharger #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add more logging to our macaroon discharger - Reduce logging on our model proxy
ale8k
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
-- With Kelvin's work on implementing Juju's side of this, we found there are no logs.
-- We are logging every time we fail to read on the websocket but this happens a lot since we act as a proxy and either side of the connection close the websocket when they are done.
I also want to get rid of this log line from the Macaroon Bakery library. It prints everytime a user is authenticated and on the INFO level which is excessive. I'm thinking the line should just be changed to a DEBUG in the library code.