Enable Postgres store tests #1040
Conversation
Signed-off-by: Babak K. Shandiz <[email protected]>
Signed-off-by: Babak K. Shandiz <[email protected]>
|
@babakks the test is passing because of a change I made a while back. I added an alternative ci.yaml that would run when only workflow files have changed to make editing workflows faster, but that should be removed I think, otherwise in situations like these you can't tell if your CI is still working. |
|
@kian99 Yeah, I figured. I just pushed a dummy commit to trigger the workflow and see if it fails. |
Signed-off-by: Babak K. Shandiz <[email protected]>
| @@ -32,7 +32,7 @@ func (s *dbSuite) TestInsertSecret(c *qt.C) { | |||
| secret := dbmodel.Secret{} | |||
| tx := s.Database.DB.First(&secret) | |||
| c.Assert(tx.Error, qt.IsNil) | |||
| c.Assert(secret.Time, qt.Equals, testTime) | |||
| c.Assert(secret.Time, qt.DeepEquals, testTime) | |||
There was a problem hiding this comment.
I'm surprised these tests weren't running before, I recall running them locally but I guess the CI was skipping them?
There was a problem hiding this comment.
Unless you set the env then they weren't running locally either?
There was a problem hiding this comment.
Pretty sure they were, I remember going through iterations of them failing and fixing them
There was a problem hiding this comment.
Yeah, that seems to be the reason.
Description
This is a side PR that enables Postgres database store tests, which was skipped due to a missing env var.
Engineering checklist
Check only items that apply