Css 4790/better error masking #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kian99
reviewed
Aug 24, 2023
internal/jujuapi/controllerroot.go
Outdated
| @@ -82,7 +82,7 @@ func (r *controllerRoot) masquerade(ctx context.Context, userTag string) (*openf | |||
| func parseUserTag(tag string) (names.UserTag, error) { | |||
| ut, err := names.ParseUserTag(tag) | |||
| if err != nil { | |||
| return names.UserTag{}, errors.E(errors.CodeBadRequest, err) | |||
| return names.UserTag{}, errors.E(errors.CodeBadRequest, err, "invalid user tag") | |||
There was a problem hiding this comment.
Just curious why is this one masking the error but the then in jimm.go when we calls parseUserTag we don't mask the error?
There was a problem hiding this comment.
my bad, I forgot to remove it.
kian99
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This allows better error messages to appear instead of being masked for list auth relations.
As per the recommendation of @alesstimec, it is a good idea to mask errors that shouldn't appear to the user, but CodeBadRequest usually means that the user did something wrong, so we need to give him better error messages.
I scanned all references to BadRequest errors, and fixed the only two that masked the errors from the users.
Fixes CSS-4790
Engineering checklist
Check only items that apply