-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/cd base #1028
ci/cd base #1028
Conversation
.github/workflows/snap.yaml
Outdated
@@ -18,7 +18,7 @@ jobs: | |||
- run: sudo snap install snapcraft --channel=7.x/stable --classic | |||
- run: mkdir -p snap | |||
- run: cp ./snaps/jimm/snapcraft.yaml ./snap/snapcraft.yaml | |||
- run: snapcraft snap --destructive-mode --output jimm.snap | |||
- run: snapcraft snap --destructive-mode --output jimmctl.snap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a snap action... @kian99 you used it right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if there's a snap action but I have used existing charm actions for releasing e.g. https://github.com/canonical/charming-actions we should look for existing Snap actions. I found https://github.com/snapcore/action-publish which I found via https://snapcraft.io/docs/ros-with-github-actions
There's also https://github.com/marketplace/actions/snapcraft-action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes I see that's the case in the release.yaml PR, I hadn't taken a look at that yet. This building one is fine, unless there is also a snapcore/build action you can use and clean up what already exists.
snaps/jimm/snapcraft.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not the correct snapcraft.yaml to edit, this one is for the JIMM server, there will be another one where the name is JAAS that needs to be renamed to jimmctl
.github/workflows/snap.yaml
Outdated
@@ -18,7 +18,7 @@ jobs: | |||
- run: sudo snap install snapcraft --channel=7.x/stable --classic | |||
- run: mkdir -p snap | |||
- run: cp ./snaps/jimm/snapcraft.yaml ./snap/snapcraft.yaml | |||
- run: snapcraft snap --destructive-mode --output jimm.snap | |||
- run: snapcraft snap --destructive-mode --output jimmctl.snap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes I see that's the case in the release.yaml PR, I hadn't taken a look at that yet. This building one is fine, unless there is also a snapcore/build action you can use and clean up what already exists.
Signed-off-by: Mina Ashraf <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comments as in #1031 otherwise lgtm
Description
creating a manually-triggered github workflow to release jimmctl snap to snapstore
Fixes CSS-4742
Engineering checklist
Check only items that apply
Test instructions
Not tested yet! running the workflow would release the snap to the snapstore, which I don't want to do.
Notes for code reviewers
Any guide on how test github actions that release packages would be appreciated