Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS-4745 Improve dev environment (debugging + controller setup) #1023

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

babakks
Copy link
Member

@babakks babakks commented Aug 3, 2023

Description

This is a side PR that enbales debugging on the master branch, and also utilizes cloud-init configuraton when bootstrapping a dev env controller. Pretty much the same things we now have on the feature-rebac branch.

Engineering checklist

Check only items that apply

  • Documentation updated
  • Covered by unit tests
  • Covered by integration tests

Copy link
Contributor

@kian99 kian99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I think this won't work as is, let me know if you've tested it and it does that would be curious.

local/jimm/add-controller.sh Show resolved Hide resolved
local/jimm/setup-controller.sh Outdated Show resolved Hide resolved
@babakks
Copy link
Member Author

babakks commented Aug 3, 2023

As far as I'm testing it, it's working, but I'm not sure if there are things that should be checked.

@babakks babakks merged commit 8139e52 into canonical:main Aug 9, 2023
1 check passed
@babakks babakks deleted the css-4745/improve-dev-env branch August 9, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants