Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main to rebac #1022

Merged
merged 3 commits into from
Aug 3, 2023
Merged

Main to rebac #1022

merged 3 commits into from
Aug 3, 2023

Conversation

kian99
Copy link
Contributor

@kian99 kian99 commented Aug 3, 2023

Description

Forward merge - main to feature-rebac, includes 2 changes,

  • Fix for grabbing tags during CI
  • Fix to defer database charm relation until username is not null.

kian99 and others added 3 commits July 24, 2023 12:01
* Defer database event when `username` is `None`

Signed-off-by: Babak K. Shandiz <[email protected]>

* Check for `event.password` being None

Signed-off-by: Babak K. Shandiz <[email protected]>

* Fix lint issues

Signed-off-by: Babak K. Shandiz <[email protected]>

* Set `ops >= 2.0.0` to match data platforms lib requirements

Signed-off-by: Babak K. Shandiz <[email protected]>

---------

Signed-off-by: Babak K. Shandiz <[email protected]>
Co-authored-by: Kian Parvin <[email protected]>
@kian99 kian99 merged commit 530b76d into canonical:feature-rebac Aug 3, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants