CSS-4792 Resolve controller jimm tag #1019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we can refer to JIMM as controller-jimm when adding relations.
alesstimec
force-pushed
the
resolve-controller-jimm-tag
branch
from
dae9f1b
to
d86334f
Compare
babakks
approved these changes
Aug 1, 2023
| @@ -1256,7 +1267,6 @@ func (s *accessControlSuite) TestCheckRelationControllerAdministratorFlow(c *gc. | |||
|
|
|||
| func (s *accessControlSuite) TestResolveTupleObjectHandlesErrors(c *gc.C) { | |||
There was a problem hiding this comment.
Since you're touching this file, can we also rename this and the following test functions to TestResolveTag... (i.e., Tag instead of Tuple)?
| @@ -88,6 +97,9 @@ func (s *relationSuite) TestAddRelationSuperuser(c *gc.C) { | |||
| c.Assert(err, gc.IsNil) | |||
| resp, err := s.jimmSuite.JIMM.OpenFGAClient.ReadRelatedObjects(context.Background(), nil, 50, "") | |||
| c.Assert(err, gc.IsNil) | |||
| // NOTE: this is a bad test because it relies on the number of related objects. So all the | |||
kian99
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
One thing we're missing here is validation that new controllers added to JIMM are not called the same thing as jimmControllerName otherwise that controller will become inaccessible. It's a niche case so possible we could skip it but shouldn't be too much work to add.
alesstimec
force-pushed
the
resolve-controller-jimm-tag
branch
from
8044420
to
a5d3f2f
Compare
alesstimec
force-pushed
the
resolve-controller-jimm-tag
branch
from
0964d80
to
a69ec46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will allow us to refer to JIMM as controller-jimm when adding relations.
Engineering checklist
Check only items that apply
Test instructions
Notes for code reviewers